[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MTD CVS update: 'mtd/fs/jffs intrep.c'




On Mon, 17 Jul 2000, Nick Ivanter wrote:

> Finn Hakansson wrote:
> 
> > On Mon, 17 Jul 2000, David Woodhouse wrote:
> >
> > >
> > > finn@xxxxxxx.org said:
> > > > Log Message:
> > > > * jffs_possibly_delete_file: Call jffs_unlink_file_from_tree only if
> > > >   we're mounting the file system.
> > >
> > > Is this related to the infinite garbage collection which I observed, or is
> > > it entirely separate?
> >
> > No. Don't think so. So far it is mostly cleanup. I'm trying to get your
> > code to be as similar to our's as possible and in a couple of minutes I
> > am going to release something nice. (I hope.)
> >
> > /Finn
> 
> I've found the the following fragment in updated intrep.c :
> ..............
>   if (raw_inode.dsize) {
>    if (raw_inode.rename) {
>     deleted_file = *(__u32 *)pos;
>    }
> ..................
> 
> As I understand, you're reading from Flash with 'deleted_file = *(__u32
> *)pos;'.
> Shouldn't it be done with flash_safe_read32() or something similar instead?
> Or I've missed something?


Oops! Yeah, you're right. I'll commit a fix in a couple of minutes. Thanks
for pointing this out!

/Finn