[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Problem with deleted files




Simon.Munton@xxxxxxx.uk said:
>  This could be fixed by always setting a node's deleted flag if the
> corresponding file's deleted flag is set, when it is written in
> jffs_write_node() and jffs_rewrite_data(). Can anyone see any problems
> with this?

Er... I thought we already did this. Yes, that's what I'd recommend. Once 
you're sure it's happy, can you commit the same change to the 
linux-2_4-branch too, please?

Simon.Munton@xxxxxxx.uk said:
> Should the filesystem fail to mount if it finds a node with no parent?
> Would it be better to just throw away such nodes, or perhaps create a
> virtual lost+found directory and put them there? 

I'd just let it mark them as deleted. JFFS2 will do that anyway - I'm not
going to bother with marking inodes as deleted. They'll just fade away when
nlink (calculated dynamically from the dirents) gets to zero.

The whole thing gets _so_ much more interesting when you no longer GC in 
strict order, and you can GC the 'deletion' nodes before you actually GC 
the nodes they're deleting... 

--
dwmw2



To unsubscribe from this list: send the line "unsubscribe jffs-dev" in
the body of a message to majordomo@xxxxxxx.com