[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: What on Earth is JFFS2 GC doing?



David Woodhouse wrote:

> vipin.malik@xxxxxxx.com said:
> >  What does this " jffs2_free_all_node_refs" do anyway and why can't it
> > do it faster :)
>
> Oh yes. I'd forgotten about that, although as the comment implies I did
> realise at the time I wrote it just how bad it might be :)

Hmm the comment is above the function " jffs2_remove_node_ref_from_ino_list", but the
fn called in the profile is "jffs2_free_all_node_refs". Are they related?

>
>
> I suppose we just have to increase the jffs2_raw_node_ref from 16 bytes to
> 20 - unless anyone's got any better suggestions?
>
> /* Hmmm. Maybe we should accept the extra space it takes and make
>    this a standard doubly-linked list? */

Care to elaborate a bit more? And what is the diff in performance that we are talking about?

Thanks

Vipin


To unsubscribe from this list: send the line "unsubscribe jffs-dev" in
the body of a message to majordomo@xxxxxxx.com