RE: JFFS2 memory leak

[David Woodhouse <dwmw2@xxxxxxx.org>]

(Frédéric, I hope you'll forgive me for quoting your private mail in public.)

On Fri, 27 Jul 2001, Frederic Giasson wrote:
> After 436 results ( were it was when I came in thin morning ), no
> flash space leak detected.  So the problem is fixed.

Cool. Thanks for finding it and testing the fix. Alan, please could you 
apply this. I'll sort out the up_and_exit() problem soon.

This fix is in handhelds.org CVS as of yesterday.

Index: readinode.c
===================================================================
RCS file: /home/cvs/mtd/fs/jffs2/readinode.c,v
retrieving revision 1.55
retrieving revision 1.56
diff -u -r1.55 -r1.56
--- readinode.c	2001/05/24 22:24:39	1.55
+++ readinode.c	2001/07/26 20:32:39	1.56
@@ -31,7 +31,7 @@
  * provisions above, a recipient may use your version of this file
  * under either the RHEPL or the GPL.
  *
- * $Id: readinode.c,v 1.55 2001/05/24 22:24:39 dwmw2 Exp $
+ * $Id: readinode.c,v 1.56 2001/07/26 20:32:39 dwmw2 Exp $
  *
  */
 
@@ -460,8 +460,11 @@
 
 	frags = f->fraglist;
 	fds = f->dents;
-	if (f->metadata)
+	if (f->metadata) {
+		if (!f->inocache->nlink)
+			jffs2_mark_node_obsolete(c, f->metadata->raw);
 		jffs2_free_full_dnode(f->metadata);
+	}
 
 	while (frags) {
 		frag = frags;

-- 
dwmw2



To unsubscribe from this list: send the line "unsubscribe jffs-dev" in
the body of a message to majordomo@xxxxxxx.com