[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: JFFS2 double free fix for 2.4.19-pre.



> This fixes a double-free which could happen when a node which represents a 
> hole in a file is garbage-collected. It also moves one debug message to a 
> higher debug level, because it annoyed me when I was trying to find the bug.
> 
> This BitKeeper patch contains the following changesets:

Please send proper patches. What you sent is not unified diff

> D34 1
> I34 1
>  * $Id: gc.c,v 1.52.2.3 2002/05/12 17:27:08 dwmw2 Exp $
> D500 1
> I501 1
> 		return 0;
> I502 12
> \
> 	/* 
> 	 * We should only get here in the case where the node we are
> 	 * replacing had more than one frag, so we kept the same version
> 	 * number as before. (Except in case of error -- see 'goto fill;' 
> 	 * above.)
> 	 */
> 	D1(if(unlikely(fn->frags <= 1)) {
> 		printk(KERN_WARNING "jffs2_garbage_collect_hole: Replacing fn with %d frag(s) but new ver %d != highest_version %d of ino #%d\n",
> 		       fn->frags, ri.version, f->highest_version, ri.ino);
> 	});
> \
> 
> == fs/jffs2/nodelist.c ==
> patch@xxxxxxx.c|20020205201839|11659|437d0aa82721716
> patch@xxxxxxx.c|20020313223046|50436
> D 1.5 02/05/12 19:34:14+01:00 dwmw2@xxxxxxx.internal +2 -2
> B torvalds@xxxxxxx.com|ChangeSet|20020205173056|16047|c1d11a41ed024864
> C
> c Move the dirent list dumping to D2
> K 50438
> O -rw-rw-r--
> P fs/jffs2/nodelist.c
> ------------------------------------------------
> 
> D34 1
> I34 1
>  * $Id: nodelist.c,v 1.30.2.4 2002/05/10 18:30:33 dwmw2 Exp $
> D72 1
> I72 1
> 	D2(while(*list) {
> 
> # Patch checksum=7088fdab

To unsubscribe from this list: send the line "unsubscribe jffs-dev" in
the body of a message to majordomo@xxxxxxx.com