[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] --cleanmarkers option in mkfs.jffs2





johan.adolfsson@xxxxxxx.com said:
>  Is there really a problem, more than that we waste space in the
> middle  of a block, or that some blocks misses erasemarkers? Does the
> fs code relies on that the block really is empty if there is a
> cleanmarker followed by a few 0xFF's? 

As of about two days ago when we sped up the mount by an order of 
magnitude, yes. I haven't yet got round to doing the full check later -- 
easy to do though now we've done the same for all the data and dnode crcs.

> in that case, the worst thing that could happen is that the write failes
> and that we have to erase the block again? 

Er, the write will fail and we'll panic at the moment. Or at least go into 
an endless loop without skipping over the offending region.

The case I'm worried about is where we get a CLEANMARKER node in the 
_middle_ of an erase block.

--
dwmw2



To unsubscribe from this list: send the line "unsubscribe jffs-dev" in
the body of a message to majordomo@xxxxxxx.com