[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: JFFS2 (ecos) broken



After modifying your patch a little to

	ri.isize = cpu_to_je32(inode->i_size);

it works fine for me.

Tested ok.

Thank you so much, you (probably) saved my life.

Regards,
Dirk

-------- Original Message --------
Subject: Re: JFFS2 (ecos) broken (31-Mrz-2004 14:19)
From:    dwmw2@xxxxxxx.com
To:      eibach@xxxxxxx.de

> On Wed, 2004-03-31 at 11:19 +0000, eibach@xxxxxxx.de wrote:
> > Hello,
> > 
> > attached is a log-file corresponding to the source code below plus two "ls" 
> > 
> > commands after closing. In the log you can see, that the filesize changes 
> > after 
> > the garbage collection that is triggered (?) by the second ls.
> 
> That's not garbage-collection. That's just the inode in question being
> dropped from the icache, so it gets re-read. When we reread it, we build
> up the whole fragtree with all 4 KiB, then we see that the last log
> entry holds isize of 0x20a and we truncate...
> 
> 	<7>Truncating fraglist to 0x0000020a bytes
> 
> It looks like jffs2_fo_write() isn't actually _setting_ isize, and it
> should. I've committed a fix to my CVS tree which hopefully some kind
> soul (CC'd) will pick up and commit to the eCos tree too if you test it
> and report that it fixed the problem.
> 
> http://lists.infradead.org/pipermail/linux-mtd-cvs/2004-March/003540.html
> http://lists.infradead.org/pipermail/linux-mtd-cvs/2004-March/003541.html
> 
> > You are right, it is just test code, but my main point is not the write 
> > loop, 
> > but the lseek command that finally fails.
> 
> Just checking :)
> 
> -- 
> dwmw2
> 
> 
> To: eibach@xxxxxxx.de
> Cc: jffs-dev@xxxxxxx.com
>     gary@xxxxxxx.com


To: dwmw2@xxxxxxx.com
Cc: jffs-dev@xxxxxxx.com
    gary@xxxxxxx.com


To unsubscribe from this list: send the line "unsubscribe jffs-dev" in
the body of a message to majordomo@xxxxxxx.com